Adding FfiType::Callback
#1814
Closed
Adding FfiType::Callback
#1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type can be used whenever we need to define a callback functions. Rather than adding the type by hand, which was quite annoying when I was doing the async work, we now can just add an item in `ffi_callback_definitions()`. This also can help avoid FFI type mismatches, like how I made the Kotlin signature input a i16 instead of an i8. Use the new type for the future continuation callback. I have another plan for callback interface callbacks. I didn't touch the foreign executor callback, I hope to work on that very soon.
|
I thought I was going to need to get some more PRs merged before moving to the second step of this, but I realized I was wrong. I just put up #1818 which includes this change and more. Let's discuss in that PR, I don't think there's much reason to merge half of the changes without the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort-of in the same sprit as #1808, but just focused on foreign callback functions. The goal is to have a single
FfiTypethat we can reuse whenever we want to add a new callback function type.With this change, if you want to add a new callback function type you just add an item in
ffi_callback_definitions(). I think this should make the process much easier. It can help avoid FFI type mismatches, like how I made the Kotlin signature input a i16 instead of an i8.Use the new type for the future continuation callback. I have another plan for callback interface callbacks. I didn't touch the foreign executor callback, I hope to work on that very soon.